[MPlayer-dev-eng] [PATCH] Bug fix for -geometry option NODAEMON

[Bjorn Danielsson]

Diego Biurrun <diego at biurrun.de> wrote:
> Sascha Sommer writes:
> > On Sunday 30 January 2005 19:56, Bjorn Danielsson wrote:
> > > The manual page says that "%" appended to an x or y position
> > > causes the corresponding value to be interpreted as a percentage
> > > of screen width/height instead of an absolute pixel offset.
> > >
> > > The code doesn't agree, it applies this interpretation to both
> > > x and y even if only one of the coordinates has a "%" suffix.
> > > The attached patch makes the code agree with the manual, which
> > > in my opinion is more sensible in this case.
> > 
> > With what vo are you testing?
> > Your patch doesn't work here with the x11 and xv vos.
> 
> Elaborate, it works for me with vo_x11, vo_xv and vo_xmga (Matrox
> G550, XFce 4.1, Debian Sarge).
> 
> I think a good test is something like
> 
> -geometry 100:100
> -geometry 100:100%
> -geometry 100%:100
> -geometry 100%:100%

I suggest testing with 99% instead of 100% to avoid interference
with window managers. Some window managers (e.g. fluxbox 0.1.14)
will override the positioning unless x + width < screenwidth - 1,
and the 100% setting leaves no margin.

-- 
Bjorn Danielsson  <mplayer-mail at dax.nu>