[MPlayer-dev-eng] [PATCH] New video filter: deblendlogo

[Oded Shimon]

On Tuesday 22 February 2005 14:57, Martin Atkins wrote:
> There seems to be a strange bug with the YV12->BGRA->YV12 path where a
> green line is introduced with some video sources at the bottom of the
> image. I can't figure out what's causing it, but some discussion on the
> #mplayerdev IRC channel led to the conclusion that it was a bug in the
> scaler. Still, if anyone can see that I'm calling it wrong or something,
> please let me know.
I dunno about the calling, TBH, I didn't even look at the code, but it gives 
me a green line too. :( So it's not swscaler or uneven res, something is 
wrong.. It's a bit of a stopper, better figure it out...

I dunno much about the filter chain, but I believe it works in a way where 
each filter says which color format it wants, and what color format it can 
give, and the filter chain takes care of the rest. That's how the 'format' 
filter works AFAIK, since the 'format' filter alone really doesn't do 
anything, all conversion is done in swscale. So can't you make your filter 
say it only wants RGBA and only gives out RGBA?...

> The attached file is the new filter implementation. The patch included
> in my last message will still work to add the filter to mplayer when built.
Other than that, amazing filter!!
See for yourself.
http://dividedsky.net/~ods15/snapshot0.png

- ods15