[MPlayer-dev-eng] [PATCH] MEncoder Multiple file 2 pass fix

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Sat Feb 26 16:55:17 CET 2005


D Richard Felker III wrote:
> On Sat, Feb 26, 2005 at 04:37:34PM +0100, Jindrich Makovicka wrote:
> 
>>D Richard Felker III wrote:
>>
>>>this is a much better solution, but the patch is slightly bad, imo.
>>>your vf_config_wrapper duplicates the sort of purpose vf_next_config
>>>is already there for. please just put the code in vf_next_config; then
>>>it will be fine to commit.
>>
>>The main reason I added it is because vf->config is called in 
>>mpcodecs_config_vo() too. Otherwise I would put this stuff to 
>>vf_next_config.
> 
> 
> hmmm..
> is there a reason mpcodecs_config_vo can't use vf_next_config?

I guess it's because it calls the first filter in a row :)

-- 
Jindrich Makovicka




More information about the MPlayer-dev-eng mailing list