[MPlayer-dev-eng] [PATCH] vf_spp: fix compiler-error and/or runtime crash

[Michael Niedermayer]

Hi

On Sunday 02 January 2005 05:49, Felix Buenemann wrote:
> Hi,
>
> I had spp crashing on me for a long time, so now I investigated the prob
> and found a fix. It happens to me that when compiled normally MPlayer would
> crash at runtime when using -vf spp, and when compiling with -g3 it would
> raise a compiler error at vf_spp.c:291 squeaking about a corrupted double
> linked list (or sth. like that ;-).

are u reporting gcc bugs here?


>
> So it seems my gcc-3.4.2 doesn't like to have to choose wether to use
> m(emory) or r(egister) for it's asm contraint (look at the "rm" (4) at
> vf_spp.c:291). I simply replaced "rm" (4) by "r" (4), I could not find a
> place in gcc docu that this syntax is actually allowed, so I just think it
> slipped through a whole of older gcc's parsing that contraint.

its certainly valid, see:
------
The simplest kind of constraint is a string full of letters, each of
which describes one kind of operand that is permitted.  Here are the
letters that are allowed:

...
`m'
     A memory operand is allowed, with any kind of address that the
     machine supports in general.

...
`r'
     A register operand is allowed provided that it is in a general
------

but OTOH, as the gcc developers dont consider things like this a bug anymore 
(see my new sig ...) iam not sure how we should deal with such things in the 
future

[...]
-- 
Michael

"In any case, just because code is syntactically "valid" GNU C doesn't 
mean gcc can always compile it." -- justification to close a gcc bug