[MPlayer-dev-eng] [PATCH] Substitution of -z command line option for vo_png suboption.

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jan 3 10:49:25 CET 2005

> Here's a patch that removes the -z command line option and adds a suboption 
> 'z=<0-9>' to vo_png using the recently committed suboption parser. I also 
> updated the manual page to reflect this change.
> Any comments or objections?  (Felix? Diego? :-) )

> -    {
> -	printf("PNG Unknown subdevice: %s\n",arg);
> -	return ENOSYS;
> +    if (subopt_parse(arg, subopts) != 0) {
> +        return ENOSYS;

Forgot that: while changing it anyway, I vote for using -1 instead of
ENOSYS, I really don't know why that was used - it seems that some vos
even include errno.h just to use it! After all we even have things like
VO_FALSE if somebody really wants to use some constants...

Reimar DÖffinger

More information about the MPlayer-dev-eng mailing list