[MPlayer-dev-eng] Re: [PATCH] don't skip first mp3 frame

[Jindrich Makovicka]

Reimar Döffinger wrote:
> Hi,
> On Tue, Jan 04, 2005 at 10:44:40AM +0100, Jindrich Makovicka wrote:
> 
>>Reimar Döffinger wrote:
>>
>>>Please upload the sample. The samplerate if the first six headers are
>>>checked to match by the demuxer, so if there are bogus parameters in the
>>>first frame the demuxer should have made sure it will be skipped.
>>
>>incoming/mp3frame1
> 
> 
> That's an avi, so the change to the audio demuxer did not make a
> difference of course...

Yes, I mentioned it in my previous post.

> But the samplerate seems to be detected correctly even without your
> patch... Can you explain more what exactly your patch is supposed to do?

Strange, for me, vanilla MPlayer detects 22050 Hz instead of correct 
44100. The patch makes the decoder return samplerate and other stuff 
based on the second frame, as in the previous versions which skipped it.

> And do you know how that file was created?

tv capture using mencoder, then a part was cut out using avidemux. I 
have more files produced by the same means, all of them work. I agree 
the file is buggy, but older mplayer releases had no trouble.

> And how does it play in other players?

I didn't try it yet.
-- 
Jindrich Makovicka