[MPlayer-dev-eng] patch: can't display mp3

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Jan 6 22:53:47 CET 2005


Hi,
On Thu, Jan 06, 2005 at 10:40:14PM +0100, Moritz Bunkus wrote:
> > That extra from variable is not needed and that cast is complete
> > nonsense. Also str should be const (and actually from should be replaced
> > by str).
> 
> Nope, there are iconv implementations whose char * parameter is NOT
> const.

Is there any justification for that or shouldn't we just consider that
broken? Anyway, then the current code makes even less sense...

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list