[MPlayer-dev-eng] [PATCH] bugfix for black bar besides gaussed vobsubs

Csillag Kristof fenwick at freemail.hu
Sat Jan 8 06:26:27 CET 2005


Hi there!

When playing a movie with a vobsub subtitle, using the swscaler gaussian
blur for nice antialiasing, sometimes we can see a black bar on the
right of the subtitle box. I uploaded a screenshot here:
http://rht.bme.hu/~lunkwill/computer/mplayer/black-column.png (60 KB)

(Look closely at the hand.)

If you want to try it:

1. wget http://rht.bme.hu/~lunkwill/computer/mplayer/sample.mkv (3 MB)
2. mplayer -vo x11 -nofs -zoom -spuaa 4 -slang hun sample.mkv 

..and watch the left hand of Bruce Willis, at the right side of the
subtitles.

  * * *

This is an error in spudec.c; there is some 8-padding for alpha_draw in
the spu images, but only the real image gets scaled up, so the padding's
alpha map has to be zeroed out. (It should be zero on the first place,
but there is some compication with interpreting 0 as 1, and 255 as 0,
because 0 has a special meaning (full transparency.)

This two-line patch fixes the mess, and removes the black bar.

-- 
Csillag Kristof <fenwick at freemail.hu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: csk-vobsub-black-bar-bugfix.patch
Type: text/x-patch
Size: 668 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050108/b304e7e5/attachment.bin>


More information about the MPlayer-dev-eng mailing list