[MPlayer-dev-eng] [PATCH] bugfix for black bar besides gaussed vobsubs

Csillag Kristof fenwick at freemail.hu
Sat Jan 8 16:10:19 CET 2005


2005-01-08, szo keltezéssel 15.33-kor Reimar Döffinger ezt írta:
> Agree, I dislike it and it should be changed. I think it's because it
> was like that in the first OSD implementation (and is used when you
> define FAST_OSD). Not 100% sure though.
I will not touch it now; it's used in too many places.

> Wouldn't 256 - s2[i] (which is by the way equivalent -s2[i]) make more
> sense than (s2[i] - 1) ^ 255 ??
Yes, of course it would. (GCC generates the same code for it, anyway.)
By the way, checking if non-zero before invertation is also unnecessary,
because -0 is 0.

Here is the new version. (See attached patch.)

Now, can we get it any more simple? :)

Csillag Kristof <fenwick at freemail.hu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: csk-vobsub-background-3.patch
Type: text/x-patch
Size: 771 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050108/aa1269c9/attachment.bin>

More information about the MPlayer-dev-eng mailing list