[MPlayer-dev-eng] [PATCH] bugfix for black bar besides gaussed vobsubs

[Reimar Döffinger]

Hi,
On Sat, Jan 08, 2005 at 01:25:31PM -0500, D Richard Felker III wrote:
> On Sat, Jan 08, 2005 at 06:24:20PM +0100, Reimar Döffinger wrote:
> > On Sat, Jan 08, 2005 at 12:08:37PM -0500, D Richard Felker III wrote:
> > > On Sat, Jan 08, 2005 at 03:33:37PM +0100, Reimar Döffinger wrote:
[...]
> > > > Wouldn't 256 - s2[i] (which is by the way equivalent -s2[i]) make more
> > > > sense than (s2[i] - 1) ^ 255 ??
> > > 
> > > I dunno, if you have a way that works it's ok, but my code is correct
> > > and not slow anyway.
> > 
> > Huh? And what about that black stripe then? That's intended??? Or what
> > do you mean?
> 
> I just mean the (s2[i] - 1) ^ 255 thing. Obviously the black stripe is
> wrong and needs to be fixed.

(s2[i] ^ 255) + 1 = one's complement + 1 = two's complement = -s2[i]
and thus als (s2[i] - 1) ^ 255 = -s2[i]
Or what are you taking about? I just can't follow...

Greetings,
Reimar Döffinger