[MPlayer-dev-eng] [PATCH] bugfix for black bar besides gaussed vobsubs

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jan 9 10:35:39 CET 2005

On Sat, Jan 08, 2005 at 11:17:15PM +0100, Csillag Kristof wrote:
> 2005-01-08, szo keltezéssel 22.06-kor Reimar Döffinger ezt írta:
> > Hi,
> > On Sat, Jan 08, 2005 at 09:49:44PM +0100, Reimar Döffinger wrote:
> > > On Sat, Jan 08, 2005 at 06:26:27AM +0100, Csillag Kristof wrote:
> > [...]
> > > I think the attached patch makes much more sense - it shifts setting the
> > > border alpha values of the scaled image to after scaling (instead of
> > > before)...
> > 
> > The old version seems obviously wrong, so I just applied...
> The old version is wrong, because in sws_spu_image the conversion of
> alpha values destroys the zeros.
> (Also, setting color makes no sense when alpha=0).
> My solution (in *-bugfix-4.patch) was to use a different (and also more
> efficient) conversion that doesn't destroy the zeros.
> Your solution (in spuaa4.diff), to set the border after the scaling,
> and not before, is also correct.
> However you can still apply my patch, on top of yours, to use the faster
> conversion routine.

I, too think that the suggested thing was both simpler and faster. Also
I think that together with the background patch it will make vo_gls
hardware OSD work with vobsubs.

Reimar Döffinger

More information about the MPlayer-dev-eng mailing list