[MPlayer-dev-eng] Re: Patch: Segfault With Subtitles + Missing Codec

Philip Chong pchong at ic.eecs.berkeley.edu
Sat Jan 15 03:20:40 CET 2005


On Fri, Jan 14, 2005 at 11:47:58PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> Are you sure this is the correct patch? I see you're *removing* NULL
> pointer check. I think you reversed it.

Sorry, I must have been asleep when I made the diff.  It was indeed
reversed.  Here's the real patch (or just use patch -R with the other
one).

-- 
Philip Chong
pchong at eecs.berkeley.edu
-------------- next part --------------
--- ../main/mplayer.c	2005-01-05 16:06:56.000000000 -0800
+++ mplayer.c	2005-01-14 18:15:01.000000000 -0800
@@ -4001,7 +4001,7 @@
   
 #ifdef USE_SUB
   // find sub
-  if(subdata && sh_video->pts>0){
+  if(subdata && sh_video && sh_video->pts>0){
       float pts=sh_video->pts;
       if(sub_fps==0) sub_fps=sh_video->fps;
       current_module="find_sub";


More information about the MPlayer-dev-eng mailing list