[MPlayer-dev-eng] [PATCH] Fix dll loading with Turkish locales

[D Richard Felker III]

On Thu, Jan 20, 2005 at 01:50:11AM +0300, Vladimir Mosgalin wrote:
> On Wed, 19 Jan 2005, D Richard Felker III wrote:
> 
> DRFI>gettext is ok by me, but setlocale is never acceptable imo. all it
> DRFI>does is break the expected behavior of all the standard c library
> DRFI>functions.
> 
> Standart C library defines which functions change behaviour after
> setlocale.. And they do it for a reason. You shouldn't assume that "they
> work correctly only in C locale".

but the way it changes them is idiotic. the _normal_ use for these
functions is to generate/parse text data in config files, data files,
network streams, etc. -- ALL CASES WHERE FORMATTING MUST BE UNIFORM
ACROSS ALL SYSTEMS! printing status messages to users is a really
trivial, hardly-used case, and certainly does not warrant breaking all
of the above except when they're wrapped by ugly setlocale calls.

> Maybe you don't understand this, but for example I have to convert
> help_mp-ru.h from outdated koi8-r encoding to more widely used cp1251
> each time I compile mplayer. Of course, script does this for me, but
> this is stupid anyway! No other software has such kind of problems.
> About 1400 packages are installed on my system and I can't remember
> anything with such kind of problems. You can run any program in any
> locale, and it just works.

this has nothing to do with setlocale but rather gettext, no?

> You think that this is egoistical, because I should modify mplayer's
> code to suit my needs instead of asking someone to do this? OK, forget
> about me. Think about people who package mplayer for my distribution.
> Officially, it supports koi8-r, koi8-u, cp1251 and iso-8859-5 encodings
> for Russian and Ukrainian languages. No one uses iso-8859-5 here, but a
> lot of people use cp1251, and a lot of people use legacy koi8 encodings

both are legacy. utf-8 is the only non-legacy encoding. :)

rich