[MPlayer-dev-eng] enhancement for yuv4mpeg output driver

[Michael Niedermayer]

Hi

On Friday 21 January 2005 00:27, Trent Piepho wrote:
> On Fri, 21 Jan 2005, Michael Niedermayer wrote:
> > i seriously doubt that gcc passes floating point numbers via registers,
> > instead its passed as a double over the stack
>
> Yes, as a double, which isn't a float, which is what mplayer uses.
>
> > but it works if u limit it to 30000 ...
>
> It doesn't work in all cases, here's one at random:
> 431/13695 -> 902/28661
>
> Why is av_d2q better if it only works in special cases?

it isnt according to your definition of "works", but that definition means 
that a output driver should guess the most likely fps value, but that is 
exactly what is flawed, a output driver should not guess, it should select 
the closest valid value

the real bug is the crap design of mplayer which "damages" the fps value, its 
very possible that the input video really has a non-trivial fps value which 
is close to a standard one, just think about someone slightly changing the 
fps to compensate for audio/video desync due to crap capture software or 
hardware

[...]
-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond