[MPlayer-dev-eng] [PATCH] correct false negative in configure check
astrange at ithinksw.com
Sat Jan 22 18:55:15 CET 2005
On Jan 22, 2005, at 9:18 AM, Diego Biurrun wrote:
> I'm a bit suspicious of this patch:
> elif hpux ; then
> elif ( cc_check && $TMPO ) ; then # QNX
> - _ld_pthread=''
> + _ld_pthread=' '
> Maybe you can explain how adding a space as pthread option helps
> Darwin. Also if you look at the line above your change, this check is
> specific for QNX.. Are you sure you are not breaking QNX?
I can't be completely sure that I'm breaking QNX, since I don't have
anything QNX to test on, but it almost certainly has the same problem
as Darwin there.
The problem is that setting _ld_pthread to '' turns off HAVE_PTHREADS
(line 2720). But if it's passed cc_check and the program runs, it
obviously has pthreads despite not needing any gcc flags for them.
Adding a space still indicates no options, but it doesn't make the test
on 2715/2720 fail. This doesn't make anything go badly wrong, but it
was disabling multithreaded encoding in libavcodec.
More information about the MPlayer-dev-eng