[MPlayer-dev-eng] [PATCH] -forceaspect option

[Oded Shimon]

On Sat, Jul 02, 2005 at 05:59:51PM +0300, Ivan Kalvachev wrote:
> On 7/1/05, Oded Shimon <ods15 at ods15.dyndns.org> wrote:
> > On Fri, Jul 01, 2005 at 11:03:19PM +0300, Jan Knutar wrote:
> > > On Friday 01 July 2005 17:42, Oded Shimon wrote:
> > >
> > > > > -x 800 -y 600 -forceaspect
> > >
> > > forceaspect sounds strange to me, since
> > > -aspect 1.33
> > > without any extra forcing would let you have 800x600 just fine.
> > >
> > > I realize you probably want to be able to use any arbitrary size
> > > though, ignoring file aspect. -ignoreaspect?
> > 
> > No, I don't want to force my own aspect, I want to force the MOVIE's
> > aspect. When giving -x and -y, the movie aspect is discarded. I want, no
> > matter what for the video to NOT exceed 800x600 (because that causes
> > mplayer to crash for me :/ ). -xy 800 usually does the trick, but not
> > always...
> > 
> > - ods15
> 
> Well, now i know what's wrong with this.
> 
> 1. It doesn't fix the segfault. 
> 2. It adds one more very confusing option. That is not needed.
> 
> Patch rejected.
> 
> Now, I do think that this feature is usable and should be avaiable in mplayer.
> The trick is to use the already existing -xy . e.g. -xy 800:600 
> I would be very happy if you make an more sophisticate parameter parsing ;)

I remember that was EXACTLY my original idea when I started making the 
patch, but for some reason I dumped that idea and switched to this. I can't 
quite remember why...

- os15