[MPlayer-dev-eng] [PATCH] Maybe fix gcc4 for problems on amd64 without breaking other arches

Guillaume POIRIER poirierg at gmail.com
Thu Jul 7 15:57:35 CEST 2005


Hi,

On 7/7/05, İsmail Dönmez <ismail at kde.org.tr> wrote:
> Oded Shimon wrote:
> > On Thu, Jul 07, 2005 at 11:52:29AM +0300, ??smail D??nmez wrote:
> >
> >>Reimar D??ffinger wrote:
> >>
> >>>Hi,
> >>>On Thu, Jul 07, 2005 at 07:36:19AM +0300, Ismail Donmez wrote:
> >>>
> >>>
> >>>>#endif
> >>>>    long xInc_shr16 = (long) (xInc >> 16);
> >>>>+   long xDstWidth = (long) dstWidth;
> >>>>    int xInc_mask = xInc & 0xffff;
> >>>>    asm volatile(
> >>>>            "xor %%"REG_a", %%"REG_a"       \n\t" // i
> >>>>@@ -2547,7 +2548,7 @@ FUNNY_UV_CODE
> >>>>            "cmp %2, %%"REG_a"              \n\t"
> >>>>            " jb 1b                         \n\t"
> >>>>
> >>>>-           :: "m" (src1), "m" (dst), "m" ((long)dstWidth), "m"
> >>>>(xInc_shr16), "m" (xInc_mask),
> >>>>+           :: "m" (src1), "m" (dst), "m" (xDstWidth), "m" (xInc_shr16),
> >>>>"m" (xInc_mask),
> >>>
> >>>
> >>>I tried something like that (making the dstWidth argument long), and it
> >>>breaks with gcc 3.3. Did you test that?
> >>
> >>No but I don't really see any reason for it to break with gcc-3.3. Diego
> >> I think you got gcc 3.3 around, can you please test this patch?
> >
> >
> > MPlayer interrupted by signal 11 in module: decode_video
> >
> >
> > Sorry, no go. :/
> 
> Looks like #ifdef amd64 is way to go :/

May this [untested] attached patch work at all?

Guillaume
-- 
Hollywood is a place where they'll pay you a thousand dollars for a
kiss and fifty cents for your soul.
 -- Marilyn Monroe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: postproc_gcc4_ifdef.diff
Type: text/x-diff
Size: 827 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050707/9ae21f12/attachment.diff>


More information about the MPlayer-dev-eng mailing list