[MPlayer-dev-eng] [PATCH] demux_mov cleanup

[The Wanderer]

Reimar Döffinger wrote:

> Hi,
> attached is a purely cosmetic patch for demux_mov.c that moves part
> of the lschunks funktion into a seperate function.

Not quite *purely* cosmetic; I haven't looked at the patch in detail,
but as a side effect of checking for stray printfs (which I try to do on
every submitted patch, since we don't usually want them - in patches
like this where none are expected, it's mostly just to reinforce the
habit), I noticed that there's an #if 0 block in case MOV_FOURCC('m',
'd', 'h', 'd') which contains several printfs and does not appear in the
separate-function version of the code. Since the code doesn't get
compiled in any case the change has no effect on functionality, but I
don't know if it's a good idea to remove such code without being sure of
why it was left there in the first place.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.