[MPlayer-dev-eng] [PATCH] x264 fast first pass

[Robert Swain]

Hello.

On 7/10/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> On 7/10/05, Jeff Clagg <snacky at ikaruga.co.uk> wrote:
> > First, I think that for consistency with the options in mplayer's other
> > encoding libs (lavc, xvid), it would be a good idea to name the option
> > "turbo" instead of "fastfirstpass."

OK. I've changed the option name to turbo for the sake of consistency.

> > > 0 - disabled (same as omission)
> >
> > Since this is the default, and since firstpass=0 has absolutely no
> > effect, I suggest not documenting it at all, and only telling users
> > about firstpass=[12].
> 
> I do not agree. I do believe that we'd better over-document than
> remove some informations that users may ask on the ML.
> 
> The valid range should be:
> .B fastfirstpass=<0\-2>
> 
> and how about :
> 0 - disabled (default)

I've changed the documentation to state that 0 means disabled and is
the default setting. Please find an updated patch attached. I'd be
interested if Loren were to just check that the patch is agreeable as
he has been the main driving force behind x264 over the last months
and its interface with MPlayer.

Regards,
Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.x264.fastfirst.2.diff
Type: application/octet-stream
Size: 4586 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050710/22fd28f2/attachment.obj>