[MPlayer-dev-eng] [PATCH] x264 fast first pass

Guillaume POIRIER poirierg at gmail.com
Mon Jul 11 19:52:29 CEST 2005


Hi,

On 7/11/05, Robert Swain <robert.swain at gmail.com> wrote:
> Hello.
> 
> On 7/11/05, Loren Merritt <lorenm at u.washington.edu> wrote:
> > On Sun, 10 Jul 2005, Robert Swain wrote:
> > > I've changed the documentation to state that 0 means disabled and is
> > > the default setting. Please find an updated patch attached. I'd be
> > > interested if Loren were to just check that the patch is agreeable as
> > > he has been the main driving force behind x264 over the last months
> > > and its interface with MPlayer.
> >
> > Nitpicks:
> > turbo=2 should also disable weight_b (it doesn't cost much, but is
> > noticeable when everything else is on fastest).
> > Fix the inconsistent indentation in the patch.
> > After that, commit.
> 
> I have added weight_b to the list. I tested removing cabac from the
> first pass too but it doesn't gain much speed and loses a little bit
> on the quality side from the final output so I thought I'd leave that
> one out. Plus that one really might not be a good idea.
> 
> Please find the final (hopefully ;-)) patch attached. I retyped the
> whitespace so hopefully it'll be OK now.
> 
> Thank you all for you comments.

Applied. Thanks!

Guillaume
-- 
Hollywood is a place where they'll pay you a thousand dollars for a
kiss and fifty cents for your soul.
 -- Marilyn Monroe




More information about the MPlayer-dev-eng mailing list