[MPlayer-dev-eng] [PATCH] CQMs in x264

[Robert Swain]

On 7/12/05, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Tue, 12 Jul 2005, Robert Swain wrote:
> 
> > I have written a small patch to add a CQM option to x264 in MEncoder.
> 
> > + else if( strncasecmp( cqm, "file", 4 ) == 0 )
> > + {
> > +     mod->param.i_cqm_preset = X264_CQM_CUSTOM;
> > +     mod->param.psz_cqm_file = strchr( cqm, ',' ) + 1;
> > + }
> 
> will lead to a segfault if cqm doesn't contain a comma.
> 
> + else if( strncasecmp( cqm, "file,", 5 ) == 0 )
> + {
> +     mod->param.i_cqm_preset = X264_CQM_CUSTOM;
> +     mod->param.psz_cqm_file = cqm + 5;
> + }

Thanks, it's things like this I need to become familiar with. Updated
patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.x264.cqm.2.diff
Type: application/octet-stream
Size: 2526 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050712/f3ccc53c/attachment.obj>