[MPlayer-dev-eng] [PATCH] Maybe fix gcc4 for problems on amd64 without breaking other arches

[Guillaume POIRIER]

Hi,

On 7/12/05, cartman <cartman at kde.org.tr> wrote:
> On Tue, Jul 12, 2005 at 10:51:27AM +0200, Guillaume POIRIER wrote:
> > Hej,
[..]
> > Here's what I think is a better patch that conditionally compiles
> > either version of the problematic line depending on the GCC version.
> >
> 
> This is very ugly but I don't see another solution unless someone with more
> asm knowledge provides a better patch.

Wow. This mail took 1 day to get delivered. Yes, this intended to be
only a temporary solution.


> > --- MPlayer-20050707/postproc/swscale_template.c      2005-06-30 07:35:26.000000000 +0200
> > +++ MPlayer-20050707-patched/postproc/swscale_template.c      2005-07-07 17:03:53.364963179 +0200
> > @@ -2546,8 +2546,11 @@
> >               "add $1, %%"REG_a"              \n\t"
> >               "cmp %2, %%"REG_a"              \n\t"
> >               " jb 1b                         \n\t"
> > -
> > +#ifdef (__GNUC__ > 4)        // GCC-3.3 makes MPlayer crash on IA-32 machines when using "g" operand here, which is needed to support GCC-4.0
> > +             :: "m" (src1), "m" (dst), "g" ((long)dstWidth), "m" (xInc_shr16), "m" (xInc_mask),
> 
> Maybe you should use C style /* comments */ here *g*

Done.

Applied a different version.

Guillaume
-- 
A lie gets halfway around the world before the truth has a chance to
get its pants on.
 -- Winston Churchill