[MPlayer-dev-eng] [PATCH] CQMs in x264

Diego Biurrun diego at biurrun.de
Fri Jul 15 10:39:45 CEST 2005


On Fri, Jul 15, 2005 at 03:59:38AM +0100, Robert Swain wrote:
> 
> I have altered the second flag of mp_msg to MSGL_INFO as I think this
> output is possibly more appropriate. I have also added a message to
> say that the CQM has loaded properly, for peace of mind.

That's not a good idea IMO, MPlayer/MEncoder are already too verbose, we
should not add to that verbosity.  It's OK to get that info in verbose
mode, otherwise any good Unix tool remains silent unless there is an
error.

Nit: I'd put a period after the sentences in the mp_msg calls.

Patch rejected.

Diego




More information about the MPlayer-dev-eng mailing list