[MPlayer-dev-eng] [PATCH] CQMs in x264
Loren Merritt
lorenm at u.washington.edu
Fri Jul 22 17:53:50 CEST 2005
On Fri, 15 Jul 2005, Robert Swain wrote:
> else if( strncasecmp( cqm, "file,", 5 ) == 0 )
> {
> mod->param.i_cqm_preset = X264_CQM_CUSTOM;
> mod->param.psz_cqm_file = cqm + 5;
> mp_msg( MSGT_MENCODER, MSGL_V, "x264: CQM file correctly loaded.\n" );
> }
At that point, you don't know that the file correctly loaded. You haven't
even checked that the file exists. If x264_encoder_open() succeeds, only
then do you know it worked.
--Loren Merritt
More information about the MPlayer-dev-eng
mailing list