[MPlayer-dev-eng] [PATCH] set/get equalizer slave mode commands

[kiriuja]

On Sat 23 Jul 2005 14:14, Reimar Döffinger wrote:
> Hi,
> the attached patch adds slave mode commands to set and get the equalizer
> settings. It also make af_equalizer use the settings for all channels
> when you use -1 as channels setting.
> Documentation part is still missing.
> Any comments? Because I intend to apply quite soon otherwise.
> I also think some commands to add (and maybe also remove filters) would
> be nice...
> Also the Gui should probably be changed to use these later on.
> 
> Greetings,
> Reimar Döffinger

I started coding something like this myself just a few weeks ago. In my
version the set command took three arguments: gain, band and channel.
It would change the gain of just one band of a channel, which would've
been more useful imho when the user would drag a slider for example.
The channel argument was optional, and if omitted or set to -1 it would
change the gain for the given band on all channels, similar to what you
did. I didn't have a get command for it's fairly useless.

But anyhow, I abandoned that project after I discovered how horribly
af_equalizer distorts the sound. It tries to hide the distortion by
divinding the output volume level by 40, but that doesn't completely
eliminate the distortion, and of course it makes the output volume 40
times lower when using the filter than when running without it.

Is it a problem of af_equalizer itself or libaf as a whole?

Having filter loading/removing commands is a good idea. I wonder if
that would also be possible with video filters.

--
kiriuja