[MPlayer-dev-eng] [PATCH] CQMs in x264

[Guillaume POIRIER]

Hi,

On 7/25/05, Robert Swain <robert.swain at gmail.com> wrote:
> Hello,
> 
> I know the previous patch didn't work, it was more a framework than
> anything else... and a plea for help. ;) But last night I couldn't
> sleep and I felt like fixing it. So please find the updated, tested to
> be working correctly and "I'm happy with it now, I think" patch
> attached.

\o/ :-)


> Diego: There's one long line I've left in the man page because the
> formatting breaks if I put it onto a new line. Feel free to play with
> the wording and formatting as you wish. :)

That'd have to be fixed. I'll have a look at it tonight.

> Does that all look OK now?

+.br
+.B cqm4iy=<list>
+.br
+.B cqm4ic=<list>
+.br
+.B cqm4py=<list>
+.br
+.B cqm4pc=<list>
+.br
+.B cqm8i=<list>
+.br
+.B cqm8p=<list>
+.br

What do each of those list correspond to ? Also, you need to add ".TP"
before each new option name.

I guess you should write smth like:
.TP
+.B cqm4iy=<list>
+custom intra 4x4 luma matrix
+.
+.TP
+.B cqm4ic=<list>
+custom....
+.
+.TP
+.B cqm4py=<list>
+custom....
+.
+.TP
+.B cqm4pc=<list>
+custom....
+.
+.TP
+.B cqm8i=<list>
+custom....
+.
+.TP
+.B cqm8p=<list>

See what I mean?


+.I NOTE:
+These lists will override the cqm option.

How about smth like "Each of these lists will override the
corresponding custom quantization matrix" ?

Looking forward for the 10th revision of your patch ;-)

Guillaume
-- 
I feel sorry for people who don't drink.
When they wake up in the morning, that's
as good as they're going to feel all day.
 -- Frank Sinatra