[MPlayer-dev-eng] [PATCH] CQMs in x264

[Diego Biurrun]

On Tue, Jul 26, 2005 at 12:20:56PM +0100, Robert Swain wrote:
> 
> On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Jul 26, 2005 at 02:26:43AM +0100, Robert Swain wrote:
> > > I posted an updated patch earlier, after saying what I said. What do
> > > you think of that one? It looks fine in man. What do you suggest I
> > > change '<option>' to? There are three options - flat, jvt and
> > > <filename>, as noted in the documentation.
> > 
> > something along the lines of
> > 
> > cqm[=<flat | jvt | <filename> >]
> > 
> > Look around the man page for examples.
> 
> I've used the xvid quant_type style and gone for cqm=<jvt|flat|<filename>>.

The [] are there for a reason most of the time, btw.  Does specifying
just cqm without parameters work?  Then add [].

> > > I did the documentation based on copy and paste and a bit of
> > > guesswork. It all looks fine using man so how am I supposed to know
> > > what's wrong with it?
> > 
> > Are we talking about the same patch?  mplayer.x264.cqm.9.diff?
> > 
> > Look at the formatting in man again, the paragraph indentation is wrong,
> > it does not resemble the other options at all.
> 
> Apologies, I thought I'd sent the patch to the ML, it turns out I'd
> only sent it to someone privately. :) Please find revision 11
> attached.
> 
> I'd like to have a line space after "The provided JM format matrix
> file is used." but everything I try breaks it.

.sp 1

But the rest of the man page does not use empty lines in these cases, so
better avoid it.

> Otherwise it really does look fine to me.

Better, but not fine.  Add a "\ " after jvt: to force a linebreak.  Then
look at the subq option to see how to keep the correct paragraph
indentation.

Are the : after the option names necessary?  Your description does not
make that clear, you're showing both variants.

What is the whole paragraph after the option descriptions about?  I
cannot figure out the connection to the cqm option.  You start talking
about lists, what lists?

> Is it worth adding a note for windows users that
> they won't be able to use full lists with cmd.exe because the
> commandline length is too great? And also that there is no way to pass
> absolute paths using cmd.exe because of ':'?

Sure, they will most likely appreciate it.

Diego