[MPlayer-dev-eng] Re: Re: Re: fast SPP - working code

[Vladimir Mosgalin]

Hi Jindrich Makovicka!

 On 2005.06.03 at 22:46:29 +0200, Jindrich Makovicka wrote next:

> Another nitpick: spp is broken on files with width%8 != 0.
> store_slice_mmx functions need to align the width first by
> width = (width+7)&~7 .
> 
> The positive side: I tried spp doday on various movies and both speed
> and quality are really amazing! I hope it will get into mainstream soon.

Thanks for the fix! I already made example shots to show defects of new
spp filter (they were quite noticeable sometimes, even on nice 352x240
resolution), but now fspp filter doesn't have any of them, the picture
is completely identical to spp.

And, of course, many thanks to Nikolaj!

For the record, the filter is 2.9-3.2 times faster than spp for me (with
-vo null -nosound). Level 5 is still impossible to use on close to dvd
resolution (720x400), level 4 works fine even on 720x576. That's Athlon
64 2Ghz (3000+).

Probably fspp parameters should be changed? It's looks strange when
filter accepts only levels 4 and 5, and the fact that "level 6" works
the same as level 4, not 5 isn't very nice too.

-- 

Vladimir