[MPlayer-dev-eng] Fixing the GCC-3.3 and scale code mess

[Luca Barbato]

Zoltan Hidvegi wrote:

> 
> Yes, that's the best solution, and it will even speed up C code on
> 64-bit machines, as the compiler no longer need to generate
> unnecessary truncate and extend instructions.  int and unsigned local
> variables and function arguments should all be changed to long and
> unsigned long, and everyone should kick the habbit of using int.  int
> and unsigned should *never* be used, if someone needs a specific data
> size, use int32_t, otherwise, use long and unsigned long.

I miss the point.

> I tend to
> like unsigned long the most, but it is too long to write, so I usually
> like to have a typedef to ulong.  But ulong is defined by some systems
> in system headers, so it is a bit of mess to get it right, because in
> C, you cannot typedef ulong if it was already typedefed before, even
> if it is the same type.

That's why you should avoid typedeffing base types...


> 
> Zoli
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 


-- 

Luca Barbato

Gentoo/linux Developer		Gentoo/PPC Operational Leader
http://dev.gentoo.org/~lu_zero