[MPlayer-dev-eng] [PATCH] frameno file

[Dominik 'Rathann' Mierzejewski]

On Thursday, 03 March 2005 at 02:19, D Richard Felker III wrote:
> On Thu, Mar 03, 2005 at 02:05:27AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > On Thursday, 03 March 2005 at 00:37, Olivier Rolland wrote:
> > > Hey,
> > > 
> > > This patch adds a -framenofile option to mencoder to specify the audio  
> > > only input file (frameno) for the 2nd and 3rd pass in 3-passes encoding  
> > > mode. It also disables the default frameno.avi file.
> > 
> > Rejected, because:
> > - indentation changes are strictly forbidden
> > - default behaviour changes have to be well-motivated and gradual
> > - calling it three-pass is confusing in light of vpass=3
> > 
> > R.
> 
> I agree with reasons 1 and 3, but not reason 2. The existing behavior
> is very stupid (if you happen to have a frameno.avi file around it
> will screw up mencoder like crazy), and this frameno pre-pass stuff
> should be phased out anyway. 

Stupid or not, this has been the behaviour of mencoder for ages, but...

> It's already been removed or marked deprecated in the docs, iirc, so
> it's totally acceptable to change how it works, or even remove it
> altogether imo..

... as you say, it's been removed from the docs, so - essentially -
I agree.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"