[MPlayer-dev-eng] New remove-logo filter

[Oded Shimon]

On Thursday 03 March 2005 07:49, Yartrebo wrote:
> As before, any comments or constructive criticism would be appreciated.

> +#define get_part_of_pixel_yv12(mpi, x, y, plane) (*(mpi->planes[(plane)] + 
(mpi->stride[(plane)] * (y)) + (x)))

You shouldn't be using multiplication in time critical areas.
The whole point of stride, is that you have a variable which sits on the line 
you are currently at, and for each pixel you add 'x', and every line you add 
'stride':

uint8_t * tmp = dmpi->planes[0];
int x, y;
for (y = 0; y < mpi->h; y++) {
  for (x = 0; x < mpi->w; x++) {
    do_stuff(tmp[j]);
  }
  tmp += dmpi->stride[0];
}

Repeat for U and V. You should probably use a separate loop for them.
(I made the same mistake BTW, even worse :)


Other than that, patch looks good.. Haven't tested it though. BTW, since you 
seen to like comments so much, you might want to use doxygen comments. They 
are pretty much the same as you have now, just built for doxygen... Check 
DOCS/tech/code-documentation.txt .

- ods15