[MPlayer-dev-eng] man_anonymous

[D Richard Felker III]

On Mon, Mar 07, 2005 at 04:40:27PM +0100, Aurelien Jacobs wrote:
> On Mon, 7 Mar 2005 10:25:45 -0500
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> > On Mon, Mar 07, 2005 at 11:55:15AM +0100, Reimar Döffinger wrote:
> > > Hi,
> > > > Isn't adding a bunch of ifdefs into all code that uses mmap a lot more
> > > > intrusive than a configure test that just puts the code, when necessary, into
> > > > config.h?  Isn't that the point of config.h?
> > > 
> > > Well, it makes configure larger (which is already a really big monster)
> > > and unfortunately some code uses MAP_ANON and some use MAP_ANONYMOUS, so
> > > we would actually need two configure checks at the moment :-(
> > 
> > Please remove both and put (void*)-1 wherever it's needed. This is
> > (always) the value of both constants and it eliminates the dependency
> > on stupid #defines that might be missing.
> 
> Huh ?
> In my bits/mman.h I have :
> #define MAP_ANONYMOUS   0x20

Oh, hahahaha. 10000l to me. I was thinking of the error return value
for mmap and didn't even read what constant we were talking about. (I
know there are a few placed mplayer uses that and has problems, when
it should just use (void*)-1...). Sorry, forget what I said about anon
maps.

Rich