[MPlayer-dev-eng] [PATCH] bigendian fix for ao_jack

[Diego Biurrun]

On Wed, Mar 23, 2005 at 01:23:26AM +0900, Chris White wrote:
> Diego Biurrun wrote:
> >
> >--- MPlayer-1.0pre6a/libao2/ao_jack.c	2004-12-07 03:24:15.000000000 +0100
> >+++ MPlayer-1.0pre6a-fixed/libao2/ao_jack.c	2005-03-08 
> >15:22:38.000000000 +0100
> >@@ -153,7 +153,11 @@
> >			m = 1;
> >			break;
> >		default:
> >+#ifndef __BIG_ENDIAN__
> >			format = AFMT_S16_LE;
> >+#else
> >+			format = AFMT_S16_BE;
> >+#endif
> >
> Actually, you don't need the #ifndef logic really, AFMT_S16_NE will just 
> apply the correct endian for you based on your system.  See the patch 
> attached for details.

> --- libao2/ao_jack.c_old	2005-02-13 20:59:19.789628272 +0000
> +++ libao2/ao_jack.c	2005-02-13 20:59:32.437705472 +0000
> @@ -103,7 +103,7 @@
>  			m = 1;
>  			break;
>  		default:
> -			format = AFMT_S16_LE;
> +			format = AFMT_S16_NE;

OK, this is a more elegant solution.  Can I assume you have tested this
on both PPC and i386?

Diego