[MPlayer-dev-eng] PATCH to support theora-exp in mplayer

[Rich Felker]

On Sat, Apr 30, 2005 at 07:25:54PM -0400, Timothy B. Terriberry wrote:
> Rich Felker wrote:
> > These must be read from the demuxer's extradata, not ds_get_packet. If
> > the demuxer currently outputs them as packets, it needs to be fixed.
> > But otherwise your theora decoder model will only work with theora
> > stored in ogg (a very broken format) and nothing else.
> 
> Well, then your vd_theora codec is also broken, because it does the
> exact same thing.

I agree. I didn't write it.

> Since I use Theora _only_ in an Ogg container, and
> since I have no real concept of how the rest of your demuxer layer works
> (nor much time or inclination to learn), you'll have to find someone
> else competent enough to make that change if you really want support for
> other containers. However, if you guys fix your vd_theora, porting the
> changes to my vd_theora-exp would probably be simple enough.

I'll see if I can figure out how, but it sounds like theora has more
than one "header packet" per stream. Can you point me to info on how
these are packed together for inclusion in sane containers? Or do we
have to make up something ourselves?

> That said, I'd suggest the patch is still worth applying even if you
> don't: it's certainly no _worse_ than the existing Theora support, and
> provides support for a smaller, more efficient, more featureful, and

OK, fair enough.

> more secure decoder library.

The old theora had security vulns? rotfl..

Rich