[MPlayer-dev-eng] [PATCH] sub_load and sub_remove slave mode commands

[Salvatore Falco]

On Mon, May 02, 2005 at 11:07:43PM -0400, kiriuja wrote:
> This is loosely based on the original Salvatore's patch, but I had to
> rewrite practically all of it. Improvements are:

    I'm happy someone is interested in the matter!

> +sub_load <subtitle_file>
> +    Loads subtitles from <subtitle_file> and displays them.
> +
> +sub_remove [<value>]
> +    If the <value> argument is present and non-negative, removes the subtitle
> +    file with index <value>. If the argument is omitted or negative, removes
> +    all subtitle files.
> +

    I do not understand this: you call sub_load giving the filename, but you
must call sub_remove with subtitle index: how can you get that index, if
you know only the subtitle filename? You should not rely on the fact that the
first subtitle file you load receives index 1, because (1) it depends on the
implementation and (2) when you load the file there could be other subtitle files
already present (multiplexed in the file or automatically loaded).

	Saluti, Salvatore Falco
-- 
"We all know Linux is great... it does infinite loops
in 5 seconds."
    [Linus Torvalds about the superiority of Linux]