[MPlayer-dev-eng] demux_mov fix for OSX 10.4

Steven M. Schultz sms at 2BSD.COM
Mon May 9 18:27:04 CEST 2005


On Mon, 9 May 2005, Nicolas Plourde wrote:

> >     Yes, it is weird - but this is the 2nd time I've encountered a  
> > program that needed to explicitly #include the two Quicktime .h files.
> >
> >     Are you also using 10.4?  The problem doesn't occur on 10.3.x

> yes Im on 10.4
	
	Wow, that is strange - not sure why a couple projects I build need
	those extra two lines.

> >   But since those two files exist in both the current (10.4) and previous
> >     releases of Quicktime would it harm things to include them?

> dont think there is any harm in doing it but why is this happening?

	Very good question.

> here is my current diff to build with on tiger

	Hmmm, instead of commenting out <math.h> I think the proper fix is
	to detect the round() function and use HAVE_ROUND (that's in the
	gtf.c patch I posted yesterday evening).

Index: libvo/gtf.c
===================================================================
RCS file: /cvsroot/mplayer/main/libvo/gtf.c,v
retrieving revision 1.1
diff -u -r1.1 gtf.c
--- libvo/gtf.c	22 Aug 2002 23:03:50 -0000	1.1
+++ libvo/gtf.c	9 May 2005 16:11:47 -0000
@@ -11,7 +11,7 @@
 //Version 0.4
 #include <stdio.h> 
 #include <stdlib.h> 
-#include <math.h> 
+//#include <math.h> 

	I think it might be better to detect and use the system's math
	routine and ifdef the local definition.


	Cheers,
	Steven Schultz




More information about the MPlayer-dev-eng mailing list