[MPlayer-dev-eng] [PATCH] vo_directx leaks when -loop 0 is used

Rich Felker dalias at aerifal.cx
Tue May 10 07:23:49 CEST 2005


On Tue, May 10, 2005 at 09:17:40AM +0800, Timothy Lee wrote:
> Dear Sascha,
> 
> >>    * GDI leaks caused by the creation of icon and brushes every time
> >>      preinit() is called
> >>    
> >>
> >
> >I think it would be better if the brush and icon were destroyed during
> >uninit()
> >Could you update your patch to do this?
> >  
> >
> Then UnregisterClass() would have to be called in uninit() as well,
> since the icon and brushes are tied to the window class. With a '-loop
> 0' option, this leads to alternating calls to RegisterClass() and
> UnregisterClass(), which is not very efficient...

This is only the case if -fixed-vo is omitted. Otherwise init/uninit
are only called once, which is the proper way to use -loop anyway...

Rich




More information about the MPlayer-dev-eng mailing list