[MPlayer-dev-eng] [PATCH] Preliminary musepack support

[Reimar Döffinger]

Hi,
On Tue, May 10, 2005 at 11:18:26AM +0200, Guillaume POIRIER wrote:
> On 5/10/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > The naming clash seems to be fixed in the latest version of the lib.
> > The attached patch uses it. Even though seeking is still completely
> > broken, I would like to apply it soon (since I don't intend to fix it
> > any time soon, like this others can improve on it more easily).
> > Is that okay with you? Aynthing you dislike about this patch?
> 
> As I don't quite see how I may comment on your code given my limited
> skills, I'd like to test it on both AMD-64 and i386 and report
> "evident" problems, like segfaults and horrible things like that.

Sure, seeking might cause segfaults though...

> Is your patch "only" supposed to support _decoding_ of Musepack audio
> files and Musepack-in-AVI ?
> (meaning that MEncoder won't generate a proper AVI movie file if I use
> an external Musepack file as the audio track).

The only Muspack-in-AVI I saw and could test were those created my
mencoder.
Mencoder will create "something" when you specify a mpc file with
-audiofile, but unfortunately mencoder saves only the lowest 2 bytes of
the fourcc, so you have to add format 0x504D to codecs.conf, and the A-V
sync values are complete nonsense since there is no frame API and
whatever, and the bitrate that demux_audio gives is some arbitrary
value, too.
Playback works though.

> Is the decoding of Matroska movie files also supposed to work with a
> Musepack audio track?

Never seen any samples... It would have to store the header of the
musepack audio in the right place (separate from the stream).

Greetings,
Reimar Döffinger