[MPlayer-dev-eng] [PATCH] Preliminary musepack support

Rich Felker dalias at aerifal.cx
Tue May 10 20:59:51 CEST 2005


On Tue, May 10, 2005 at 08:56:10PM +0200, Reimar Döffinger wrote:
> Hi,
> On Tue, May 10, 2005 at 12:14:18PM -0400, Rich Felker wrote:
> > On Tue, May 10, 2005 at 11:02:27AM +0200, Reimar Döffinger wrote:
> > > The naming clash seems to be fixed in the latest version of the lib.
> > > The attached patch uses it. Even though seeking is still completely
> > > broken, I would like to apply it soon (since I don't intend to fix it
> > > any time soon, like this others can improve on it more easily).
> > > Is that okay with you? Aynthing you dislike about this patch?
> > 
> > Yes, the fact that it demuxes random amounts of data rather than
> > complete packets, and probably doesn't have correct timestamps
> > whatsoever.. We need more valid demuxers, not more broken ones..
> 
> Yes, that's what keeps both musepack-in-avi and seeking from working.
> But I won't be the one to fix it (and judging by the general activity in
> thsi area nobody will do that), so you only have the choice between
> getting a broken demuxer or none...
> So everybody vote, the majority wins *g*

Just copy-and-paste the decoder code that reads a packet into the
demuxer. I don't care if it's slow as hell as long as it has valid
output. Someone can optimize it later..

Rich




More information about the MPlayer-dev-eng mailing list