[MPlayer-dev-eng] [PATCH] Online audio stream switching

[Moritz Bunkus]

Hey,

On Wednesday 11 May 2005 07:19, Michael Behrisch wrote:
> OK, Rich has warned me that this is going to happen. The vorbis streams 
> have different headers which result in different decoding options needed
> for the streams. Nevertheless fix is attached, although the matroska
> people should say whether they consider calling mkv_open_audio
> for all vorbis streams (in case the initial stream is vorbis) a bad
> hack.

It memleaks: new_sh_audio is called for each Vorbis track. It also will
not work AT ALL at the moment because it sends the first three packets
down the audio demuxer chain. If you have multiple Vorbis tracks then
the headers of all will be sent downstream.

You obviously "only" need the decoding of the codec private
element. Unfortunately (or fortunately) this will be gone in a few days
anyway because Nico is in the process of fixing demux_ogg, demux_mkv and
ad_vorbis to use the extradata and not the first three
packets. Therefore demux_mkv will probably not need to decode its codec
private element anymore.

BTW: Audio switching in the demuxer like this is a totally stupid hack
in general. Just my 2c.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050511/d447de97/attachment.pgp>