[MPlayer-dev-eng] [PATCH] Preliminary musepack support

[Rich Felker]

On Wed, May 11, 2005 at 10:32:42PM +0200, Amiaux Benoit wrote:
> Hello,
> 
> I'm one of the guys who ported libmusepack to *nix.
> Here's my opinion on the topic.
> Current decoder is able to playback musepack-only audio files fine. Yes, sv7 
> bitstream is bad. Yes, seeking is an issue. Current decoder has a slow but 
> bit-perfect implementation of seeking. 
> Another issue with seeking is that there are no limits to block dependencies. 
> We had once a file with something like 1024 blocks dependencies, which 
> obviously isn't nice for packetizing the bitstream. I wish you all good luck 

It's not the end of the world. Decoding will just produce some
junk/noise for a while after seeking, but eventually it will recover.

> if you want to make a proper implementation around that in mpc-in-avi.
> So what about musepack support in mplayer ?
> A library of the encoder is currently in the making (which will be open-source 
> too btw). Hopefully it'll make it much more easier to make a real bitstream 
> for musepack, and why not, even choose nut or matroska as a 'native' 
> container.

IMO a codec should not have a 'native' container. For audio-only files
you really don't even need a container as long as you have some decent
way of identifying packet starts like mpeg does...

> So if any of you wants to work on musepack, I can only suggest to either do it 
> completely, come help us, and put up a new bitstream, we'll modify decoder 
> lib accordingly, mplayer will be able to mux/demux/play it properly. 

We need to be able to play the existing files already out there. Of
course for future stuff the format should be fixed, but that doesn't
change the fact that we need to deal with what already exists in a
sane way.

> Or mplayer could be restricted to play audio-only musepack files, and seeking 
> will be relatively slow.

??

> We already have vorbis in AVI, please no broken mpc in AVI.

Both can be done entirely correctly, albeit not necessarily
efficiently. If you think it's broken you don't understand AVI.

Rich