[MPlayer-dev-eng] [PATCH] Preliminary musepack support

[Guillaume POIRIER]

Hi,

On 5/12/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hi,
> 
> On 5/10/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> > Hi,
> >
> > On 5/10/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > Hi,
> > > On Wed, Mar 02, 2005 at 12:07:11PM +0100, Reimar D?ffinger wrote:
> > > > Another update - unfortunately there still is an naming clash between
> > > > the random_int functions in libfaad2 and libmusepack - so MPlayer won't
> > > > compile with gcc 3.3.x when you use both - with gcc 3.4.x it compiles
> > > > but crashes when you use libfaad2 :-(
> > >
> > > The naming clash seems to be fixed in the latest version of the lib.
> > > The attached patch uses it. Even though seeking is still completely
> > > broken, I would like to apply it soon (since I don't intend to fix it
> > > any time soon, like this others can improve on it more easily).
> > > Is that okay with you? Aynthing you dislike about this patch?
> >
> > As I don't quite see how I may comment on your code given my limited
> > skills, I'd like to test it on both AMD-64 and i386 and report
> > "evident" problems, like segfaults and horrible things like that.
> 
> Ok, I tested on AMD-64, and it doesn't work.... for the very simple
> reason that I can't compile Musepack on AMD-64. I'll see if more
> experimental versions feature the A-64 port.

I tested on i386 with libmusepack 1.1 and 1.2 without success. 1.1
isn't detected by configure, why 1.2 produces a link error at the very
end of the compile process.
If you need a log, I can re-run the test.

Guillaume

PS: with 1.1, that's what config.log reads:
============ Checking for musepack support ============

#include <mpcdec/mpcdec.h>
int main(void) { mpc_streaminfo info; mpc_streaminfo_init(&info); return 0; }

cc     /tmp/mplayer-conf-22648-23852.c -o /tmp/mplayer-conf-19070-23852.o -lmpcd
ec -lm
/tmp/mplayer-conf-22648-23852.c:1:27: mpcdec/mpcdec.h: No such file or directory
/tmp/mplayer-conf-22648-23852.c: In function `main':
/tmp/mplayer-conf-22648-23852.c:2: error: `mpc_streaminfo' undeclared (first use
 in this function)
/tmp/mplayer-conf-22648-23852.c:2: error: (Each undeclared identifier is reporte
d only once
/tmp/mplayer-conf-22648-23852.c:2: error: for each function it appears in.)
/tmp/mplayer-conf-22648-23852.c:2: error: syntax error before "info"
/tmp/mplayer-conf-22648-23852.c:2: error: `info' undeclared (first use in this f
unction)

ldd /tmp/mplayer-conf-19070-23852.o
ldd: /tmp/mplayer-conf-19070-23852.o: No such file or directory



and that's what is in /usr/local/include/musepack/
config_types.h  huffman.h  musepack.h  requant.h
decoder.h       math.h     reader.h    streaminfo.h