[MPlayer-dev-eng] [PATCH] Athlon 64 configure script support

Corey Hickey bugfood-ml at fatooh.org
Thu May 26 08:28:02 CEST 2005


Guillaume POIRIER wrote:
> Hi,

> The patch seems fine.
> Tested in 32-bit mode with gcc-2.95 and 3.4.4. Works fine. I'll try it
> in 64 bit mode ASAP.
> 
> Guillaume
> 

Unless I'm mistaken, the patch doesn't affect 64-bit operation because
it lies within the:

case "$host_arch" in
  i[3-9]86|x86|x86pc|k5|k6|k6-2|k6-3|pentium*|athlon*|i586-i686)


I've attached a patch for the amd64|x86_64 case. It might or might not
be applicable as-is; this is my first time really delving into the
configure file and I'm not familiar with it at all. I've tested my patch
with gcc versions 3.3.6 and 3.4.4; mplayer configures, builds, and runs
on each.

Some notes:
1. If runtime cpu detection is enabled, _mcpu and _march are both set to
the empty string. I don't know if this is the right thing to do; the
original version sets both of them empty regardless.

2. Unless I'm mistaken, this patch will prevent building mplayer on a
64-bit amd64 system with a gcc earlier than 3.3. Guillaume mentioned
that "In 64-bit mode, that's not much of a problem as I think only
gcc-3.3, 3.4 and up are officially supported,". I, as well, think that
is the case, but I haven't been able to verify it. Is the consensus that
this is true?

3. The original configure doesn't include support for --target on x86_64
arch. Neither does my patch. Should support for --target be there?

-Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 64-bit-athlon64-optimization.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050525/f6c5579b/attachment.asc>


More information about the MPlayer-dev-eng mailing list