[MPlayer-dev-eng] [mencoder] Added aspect when using -ovc copy

[Rich Felker]

On Sun, May 29, 2005 at 09:45:07PM +0200, Carsten Otto wrote:
> Hello!
> 
> I noticed mencoder does not use the correctly extracted aspect
> information from the source file (xvid, encoded from HDV). Adding the
> following line to mencoder.c helps:
> 
> line 738
>  if (sh_video->bih) {
>                                         
> mux_v->bih=malloc(sh_video->bih->biSize);
> +                                        mux_v->aspect=sh_video->aspect;
>                                          memcpy(mux_v->bih,
> sh_video->bih, sh_video->bih->biSize);
>                                  }
> 
> 
> mux_v->aspect=sh_video->aspect;
> 
> mux_v->bih holds all relevant sizes (like width, height), but
> mux_v->aspect is not set at all (is there a reason?).
> 
> I found a very huge discussion about ODML features, but did not quite
> understand it. Please tell me if there is a reason to _not_ put the
> aspect into the stream information.
> 
> I'd like to see this patch applied into some future version because
> copying HDV instead reencoding saves a lot of time.
> 
> I am new to patching, so please tell me if you need a better diff file.

The aspect of the source file is not the correct aspect for the output
file. You can only get aspect from the end of the filter chain, and
afaik this is done already. Look at ve_lavc.c

Rich