[MPlayer-dev-eng] [PATCH] MinGW compile fix, header order policy suggestion
Nico Sabbi
nsabbi at tiscali.it
Tue May 31 13:49:35 CEST 2005
Reimar Döffinger wrote:
>Hi,
>On Tue, May 31, 2005 at 12:26:55PM +0300, Ivan Kalvachev wrote:
>
>
>>I don't think this needs to be enforced because it is an good
>>programer writing style.
>>
>>
>
>Well, that probably means we have very few good programmers?
>
I admit that I made a mistake (cola accepted), but generally speaking
I invite you to keep considerations like this for yourself, please.
Code may occasionally suck, but not necessarily a programmer sucks as a
consequence.
Should we conclude that the main programmers who brought mplayer to life
suck
because there are thousand of hacks all over the code? I don't think so
>>As for the current situation, fixing this way is even worse than not
>>fixing it. The right way is to avoid all possible collisions and
>>change STREAM_SEEK to MP_STREAM_SEEK. Otherwise the assigned value may
>>
>>
>
>But for consistency all STREAM_* defines would have to be renamed...
>That would be a gigantic patch!
>
>
I agree with you that it's not the case
More information about the MPlayer-dev-eng
mailing list