[MPlayer-dev-eng] [PATCH] OSD: audio switching visualization
Paul TT
paultt at hackerjournal.it
Sun Nov 6 16:46:44 CET 2005
On Sun, 6 Nov 2005 15:29:04 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hi,
> On Sun, Nov 06, 2005 at 03:28:58AM +0100, Paul TT wrote:
> > this patch adds the visualization of selected audio track, on the
go,
> > when switched with # key.
> > (now it supports DVD and MKV files, i'm working on ogg and mpeg
> > support too...)
>
> I don't like every demuxer that supports it to have an extra function,
> esp. as they already have code for "creating" the language code at
other
> places (for -identify output I think).
> Maybe you could look if it gets simpler if you add another field for
> the language to the sh_audio_t struct (the one that also contains the
audio id).
i copied directly the way the code for osd_show_sub_visibility works...
maybe this should go in another patch which resolves this two issues?
More information about the MPlayer-dev-eng
mailing list