[MPlayer-dev-eng] [PATCH] OSD cleanup

[Paul TT]

On Thu, 10 Nov 2005 16:45:22 -0600
Joey Parrish <joey at nicewarrior.org> wrote:

> On Thu, Nov 10, 2005 at 12:26:29AM +0100, Paul TT wrote:
> > On Tue, 8 Nov 2005 18:51:39 +0100
> > Alban Bedel <albeu at free.fr> wrote:
> > > The subtitles switching stuff is a total mess, i intend to move
> > > that code out of main() later so i currently left it more or less
> > > as is.
> > 
> > ...
> > i'll try yr patch as soon as i'll be able to do :-)
> 
> I just committed code that broke your patch, so here's another
revision
> of the OSD cleanup which takes into account the border control
message.
> Applies cleanly to latest CVS.


tried the patch:

three points, up to now, in term_osd:
. behaviour of 'o' key (osd): in term mode i think it should only
notify enabled/disabled and not the other two conditions
. 'd' key (frame_drop): is it correct to let it show 'framedropping:
<state>' also for audio only files?
. ']'... (speed_mult's): when changing speed, the osd "speed: 1.1x"
overwrites the line which tells the audio chain rebuilt parameters
("Building audio filter chain..."), it should not, if possible, IMHO :-)

in video out mode:
. the displayed % (the one after the time, between '()' ) of the movie
is shown only when seeking back/forwards... which very is good, since
before didn't act this way. but IMHO, it could be good also if it's
shown when switching osd_level sith the 'o' key....

about these, i really don't have (now) the time to hack, apply, then
reextract the patch, sorry... maybe i'll can do when this patch will be
applied.....

so, the question:
when will this patch be applied????? :-)))) (i think it can, it seems
reliable, and since nobody yet complained ;-))
i would like then to recode my patch about audio switching osd
based on this one :-)