[MPlayer-dev-eng] Re: [PATCH] add -endpos support in mplayer too::2nd try

[Alban Bedel]

On Fri, 25 Nov 2005 11:23:48 +0100
Paul TT <paultt at hackerjournal.it> wrote:

> On Thu, 17 Nov 2005 21:29:48 +0100
> Alban Bedel <albeu at free.fr> wrote:
> 
> > On Thu, 17 Nov 2005 19:05:47 +0100
> > Paul TT <paultt at hackerjournal.it> wrote:
> > 
> ...
> 
> > > 
> > > NOTE2: there should be, now or then, by me or by someone else, an
> effort
> > > to move parse_at_end function in a place shared by both mplayer and
> > > mencoder. when the patch will be applied, i'll do the task...
> > 
> > imho this should be done rigth away. Attached is a patch that add the
> new
> > option type. I didn't tested it so it might have some little pbs.
> 
> all right, there's something i don't understand. prob it's because i'm
> too dumb ;)
> 
> yr function does work. it fills correctly the two fields in the
> structure.
> 
> but i've got a problem using them.
> in cfg-common.h i added the line:
>         {"endpos", &end_at, CONF_TYPE_TIME_SIZE, 0, 0, 0, NULL},
> in which end_at is the name of the struct i wish to use.
> starting with mencoder.c, for this is the first which should work as
> before, i inited end_at:
> static m_time_size_t * end_at=NULL;

Use a staticaly allocated struct and not a pointer. As in:
static m_time_size_t end_at = { 0, 0 };

	Albeu