[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

[Dominik 'Rathann' Mierzejewski]

On Sunday, 27 November 2005 at 02:44, The Wanderer wrote:
> On 11/13/2005 05:38 PM, Dominik 'Rathann' Mierzejewski wrote:
> 
> >On Sunday, 13 November 2005 at 20:07, Roberto Togni wrote:
> >
> >>There was both seek functions returning int and seek functions
> >>returning void before the demuxer patch, but in every case the
> >>return value was ignored. Probably i forgot to change these to
> >>void. If we prefer to change them all to int we can talk about it,
> >>but if we don't do anything with the result i see no reason to do
> >>it.
> >
> >The return values are indeed ignored everywhere. Here's a patch that
> >makes all the remaining non-void demuxer seek/close functions void.
> >Apply it or decide on the return value semantics. ;)
> 
> What's the status of this patch?

Undecided, because Reimar and Rich didn't agree either way.

> (Also, for my own records, am I correct in understanding that this patch
> obsoletes the one posted earlier in the same thread under the filename
> mplayer-warnings?)

No, it's only a part of that one. I should resubmit the rest separately.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"