[MPlayer-dev-eng] Re: [PATCH] OSD cleanup

[Ivan Kalvachev]

2005/11/25, Alban Bedel <albeu at free.fr>:
> On Fri, 18 Nov 2005 17:52:47 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
>
> > On Fri, Nov 18, 2005 at 01:53:02PM +0100, Alban Bedel wrote:
> > > On Thu, 17 Nov 2005 23:46:45 +0200
> > > Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> > >
> > > > The code seems to be committed and I find this new behaviour disgusting.
> > > > When I cycle trough modes using 'o' i see one "osd disable" and 3 "osd
> > > > enable" that also hide the timer mode, so it now basically less
> > > > verbose that before "osd en/disable" patch.
> > >
> > > Hmm i really don't see what your are talking about, here nothing changed in
> > > the behaviour of the osd command (tested with vo x11 and xv).
> >
> > Same here.  What is everybody talking about?
>
> The usual stuff, to cry out lound about un-checked facts, or flame
> commiters on cvs-log their is ppl. To do contructive and helfull
> things, like actually reviewing or testing patches before they are
> applied, a lot less. Sad but well ...

Don't you think you are a litel bit too arrogant?
You had messed something and then blindly refuse to acknowledge there
is problem.

Well, If you had tried to cycle through osd levels with 'o' key you
would have notice that "osd enable" doesn't vanish and keeps staying
covering the OSD timer (that is visible at osd_leves 2 and 3).

I had given you more than enough time to fix it by yourself, but you
were ignorant.
So I make some patch I can just hope it is right(tm).

Patch attached. If there is not better fix I will apply it (soon).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osd_timer.patch
Type: application/octet-stream
Size: 639 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051127/6d9fb106/attachment.obj>